fix: Respond with HTTP code 413, when request size is too big

src/api/ruma_wrapper/axum.rs

@@ -1,11 +1,10 @@
-use std::{collections::BTreeMap, iter::FromIterator, str};
+use std::{collections::BTreeMap, error::Error as _, iter::FromIterator, str};
-use std::error::Error as _;
 
 use axum::{
     body::Body,
     extract::{FromRequest, Path},
     response::{IntoResponse, Response},
-    RequestExt, RequestPartsExt,
+    RequestPartsExt,
 };
 use axum_extra::{
     headers::{authorization::Bearer, Authorization},
@@ -49,8 +48,7 @@ where
         }
 
         let (mut parts, mut body) = {
-            let limited_req = req.with_limited_body();
+            let (parts, body) = req.into_parts();
-            let (parts, body) = limited_req.into_parts();
             let body = axum::body::to_bytes(
                 body,
                 services()
@@ -61,13 +59,13 @@ where
             )
             .await
             .map_err(|err| {
-                if err.source()
+                if err
-                    .as_ref()
+                    .source()
-                    .and_then(|err| err.source())
                     .is_some_and(|err| err.is::<http_body_util::LengthLimitError>())
                 {
                     Error::BadRequest(ErrorKind::TooLarge, "Reached maximum request size")
                 } else {
+                    error!("An unknown error has occurred: {err}");
                     Error::BadRequest(ErrorKind::Unknown, "An unknown error has occurred")
                 }
             })?;

src/main.rs

@@ -2,7 +2,7 @@ use std::{future::Future, io, net::SocketAddr, sync::atomic, time::Duration};
 
 use axum::{
     body::Body,
-    extract::{DefaultBodyLimit, FromRequestParts, MatchedPath},
+    extract::{FromRequestParts, MatchedPath},
     middleware::map_response,
     response::{IntoResponse, Response},
     routing::{any, get, on, MethodFilter},
@@ -240,13 +240,7 @@ async fn run_server() -> io::Result<()> {
                 ])
                 .max_age(Duration::from_secs(86400)),
         )
-        .layer(map_response(set_csp_header))
+        .layer(map_response(set_csp_header));
-        .layer(DefaultBodyLimit::max(
-            config
-                .max_request_size
-                .try_into()
-                .expect("failed to convert max request size"),
-        ));
 
     let app = routes(config).layer(middlewares).into_make_service();
     let handle = ServerHandle::new();