From a24a97f88091a70f3b3c75f762c09a5a7b83b074 Mon Sep 17 00:00:00 2001 From: Peter Bieringer Date: Sat, 16 Mar 2024 18:04:19 +0100 Subject: [PATCH] improve/extend mkcol logging --- radicale/app/mkcol.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/radicale/app/mkcol.py b/radicale/app/mkcol.py index 94207e32..5bccc50c 100644 --- a/radicale/app/mkcol.py +++ b/radicale/app/mkcol.py @@ -52,8 +52,12 @@ class ApplicationPartMkcol(ApplicationBase): logger.warning( "Bad MKCOL request on %r: %s", path, e, exc_info=True) return httputils.BAD_REQUEST - if (props.get("tag") and "w" not in permissions or - not props.get("tag") and "W" not in permissions): + collection_type = props.get("tag") or "UNKNOWN" + if props.get("tag") and "w" not in permissions: + logger.warning("MKCOL request %r (type:%s): %s", path, collection_type, "rejected because of missing rights 'w'") + return httputils.NOT_ALLOWED + if not props.get("tag") and "W" not in permissions: + logger.warning("MKCOL request %r (type:%s): %s", path, collection_type, "rejected because of missing rights 'W'") return httputils.NOT_ALLOWED with self._storage.acquire_lock("w", user): item = next(iter(self._storage.discover(path)), None) @@ -71,6 +75,7 @@ class ApplicationPartMkcol(ApplicationBase): self._storage.create_collection(path, props=props) except ValueError as e: logger.warning( - "Bad MKCOL request on %r: %s", path, e, exc_info=True) + "Bad MKCOL request on %r (type:%s): %s", path, collection_type, e, exc_info=True) return httputils.BAD_REQUEST + logger.info("MKCOL request %r (type:%s): %s", path, collection_type, "successful") return client.CREATED, {}, None