oss/Radicale
oss/Radicale
1
0
Fork 0
mirror of https://github.com/Kozea/Radicale.git synced 2025-06-26 16:45:52 +00:00
Code Wiki Activity

Do not read server info by bind to avoid needless network trafic.

Browse source
This commit is contained in:
Dipl. Ing. Péter Varkoly 2025-05-31 13:36:59 +02:00
parent 8318feacce
commit 95b3944ade
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
radicale/auth/ldap.py
View file

@ -226,7 +226,7 @@ class Auth(auth.BaseAuth):
except Exception as e: except Exception as e:
logger.debug(f"_login3 error 1 {e} (reader)") logger.debug(f"_login3 error 1 {e} (reader)")
pass pass
if not conn.bind(): if not conn.bind(read_server_info=False):
logger.debug("_login3 cannot bind (reader)") logger.debug("_login3 cannot bind (reader)")
raise RuntimeError("Unable to read from LDAP server") raise RuntimeError("Unable to read from LDAP server")
logger.debug(f"_login3 bind as {self._ldap_reader_dn}") logger.debug(f"_login3 bind as {self._ldap_reader_dn}")
@ -257,7 +257,7 @@ class Auth(auth.BaseAuth):
conn.start_tls() conn.start_tls()
except self.ldap3.core.exceptions.LDAPStartTLSError as e: except self.ldap3.core.exceptions.LDAPStartTLSError as e:
raise RuntimeError(f"_login3 StartTLS Error: {e}") raise RuntimeError(f"_login3 StartTLS Error: {e}")
if not conn.bind(): if not conn.bind(read_server_info=False):
logger.debug(f"_login3 user '{login}' cannot be found") logger.debug(f"_login3 user '{login}' cannot be found")
return "" return ""
tmp: list[str] = [] tmp: list[str] = []