oss/FrankerFaceZ
oss/FrankerFaceZ
1
0
Fork 0
mirror of https://github.com/FrankerFaceZ/FrankerFaceZ.git synced 2025-09-17 02:16:54 +00:00
Code Wiki Activity

node.remove() exists, so why have I been doing node.parentElement.removeChild(node). I am literally the worst.

Browse source
This commit is contained in:
SirStendec 2017-12-01 15:36:18 -05:00
parent ddee1e3bb5
commit fcc3cab35f
9 changed files with 10 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/modules/main_menu/components/changelog.vue
View file

@ -28,7 +28,7 @@ export default {
const btn = container.querySelector('#ffz-old-news-button');
if ( btn )
btn.addEventListener('click', () => {
btn.parentElement.removeChild(btn);
btn.remove();
const old_news = container.querySelector('#ffz-old-news');
if ( old_news )
this.fetch(`${SERVER}/script/old_changes.html`, old_news);

2
src/modules/main_menu/components/home-page.vue
View file

@ -89,7 +89,7 @@ export default {
async: true,
charset: 'utf-8',
src: 'https://platform.twitter.com/widgets.js',
onLoad: () => el.parentElement.removeChild(el)
onLoad: () => el.remove()
}));
}

4
src/modules/main_menu/index.js
View file

@ -121,7 +121,7 @@ export default class MainMenu extends Module {
main.classList.remove('ffz-has-menu');
if ( this._menu ) {
main.removeChild(this._menu);
this._menu.remove();
this._vue.$destroy();
this._menu = this._vue = null;
}
@ -151,7 +151,7 @@ export default class MainMenu extends Module {
else
old_main.classList.remove('ffz-has-menu');
old_main.removeChild(this._menu);
this._menu.remove();
main.appendChild(this._menu);
this._vue.$children[0].maximized = maximized;

2
src/modules/metadata.js
View file

@ -240,7 +240,7 @@ export default class Metadata extends Module {
el.popper.destroy();
el.tooltip = el.popper = null;
el.parentElement.removeChild(el);
el.remove();
}
};