oss/FrankerFaceZ
oss/FrankerFaceZ
1
0
Fork 0
mirror of https://github.com/FrankerFaceZ/FrankerFaceZ.git synced 2025-08-30 01:40:55 +00:00
Code Wiki Activity

Rip out the weekly/monthly HLLs - they're redundant

Browse source 
The weekly data can be constructed much more flexibly by just using the
daily data.
This commit is contained in:
Kane York 2016-01-15 20:54:30 -08:00
parent 9ca9b6b213
commit e117766eb6
8 changed files with 76 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

15
socketserver/server/usercount_test.go
View file

@ -32,12 +32,10 @@ func TestUniqueConnections(t *testing.T) {
uniqueUserChannel <- uuid
}
TCheckHLLValue(t, TestExpectedCount, readHLL(periodDaily))
TCheckHLLValue(t, TestExpectedCount, readHLL(periodWeekly))
TCheckHLLValue(t, TestExpectedCount, readHLL(periodMonthly))
TCheckHLLValue(t, TestExpectedCount, readCurrentHLL())
token := <-uniqueCtrWritingToken
uniqueCounters[periodDaily].End = time.Now().In(counterLocation).Add(-1 * time.Second)
uniqueCounter.End = time.Now().In(counterLocation).Add(-1 * time.Second)
uniqueCtrWritingToken <- token
rolloverCounters_do()
@ -48,17 +46,16 @@ func TestUniqueConnections(t *testing.T) {
uniqueUserChannel <- uuid
}
TCheckHLLValue(t, TestExpectedCount, readHLL(periodDaily))
TCheckHLLValue(t, TestExpectedCount*2, readHLL(periodWeekly))
TCheckHLLValue(t, TestExpectedCount*2, readHLL(periodMonthly))
TCheckHLLValue(t, TestExpectedCount, readCurrentHLL())
// Check: Merging the two days results in 2000
// note: rolloverCounters_do() wrote out a file, and loadHLL() is reading it back
// TODO need to rewrite some of the test to make this work
var loadDest PeriodUniqueUsers
loadHLL(periodDaily, testStart, &loadDest)
loadHLL(testStart, &loadDest)
token = <-uniqueCtrWritingToken
loadDest.Counter.Merge(uniqueCounters[periodDaily].Counter)
loadDest.Counter.Merge(uniqueCounter.Counter)
uniqueCtrWritingToken <- token
TCheckHLLValue(t, TestExpectedCount*2, loadDest.Counter.Count())