From c3ec40b8ea9de30f9b0eb5be6e65ba98274e0d22 Mon Sep 17 00:00:00 2001 From: SirStendec Date: Mon, 4 Dec 2017 21:37:26 -0500 Subject: [PATCH] Fix a leak in the new metadata stuff with pop-ups. Fix the click handler for metadata not getting the most recent data. --- src/modules/metadata.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/modules/metadata.js b/src/modules/metadata.js index 6c2cde3c..f592e77d 100644 --- a/src/modules/metadata.js +++ b/src/modules/metadata.js @@ -239,7 +239,10 @@ export default class Metadata extends Module { if ( el.popper ) el.popper.destroy(); - el.tooltip = el.popper = null; + if ( el._ffz_destroy ) + el._ffz_destroy(); + + el._ffz_destroy = el.tooltip = el.popper = null; el.remove(); } }; @@ -322,7 +325,7 @@ export default class Metadata extends Module { if ( btn.disabled || btn.classList.contains('disabled') || el.disabled || el.classList.contains('disabled') ) return false; - def.click.call(this, data, e, () => refresh_fn(key)); + def.click.call(this, el._ffz_data, e, () => refresh_fn(key)); }); if ( def.popup )