Fix an issue with Raven erroring when error reporting is disabled.

Fix an error with featured emote sets when a room does not exist or is being destroyed.
Fix an error with the host menu when autohost settings failed to load.

changelog.html

@@ -1,4 +1,11 @@
-<div class="list-header">4.0.0-beta2.16<span>@61e6d676fdac89cf0592</span> <time datetime="2018-04-12">(2018-04-12)</time></div>
+<div class="list-header">4.0.0-beta2.17<span>@dce1b0c5268bdd3fe086</span> <time datetime="2018-04-13">(2018-04-13)</time></div>
+<ul class="chat-menu-content menu-side-padding">
+	<li>Fixed: An issue in automatic error reporting potentially swallowing errors when error reporting is disabled.</li>
+	<li>Fixed: An issue when receiving featured channels for a channel that is being destroyed.</li>
+	<li>Fixed: An issue rendering the auto-hosting menu when some data has failed to load.</li>
+</ul>
+
+<div class="list-header">4.0.0-beta2.16<span>@9fac4d6cabd486c45f4e</span> <time datetime="2018-04-12">(2018-04-12)</time></div>
 <ul class="chat-menu-content menu-side-padding">
 	<li>Fixed: Emote menu sections always starting as collapsed.</li>
 </ul>

src/main.js

@@ -100,7 +100,7 @@ class FrankerFaceZ extends Module {
 FrankerFaceZ.Logger = Logger;
 
 const VER = FrankerFaceZ.version_info = {
-	major: 4, minor: 0, revision: 0, extra: '-beta2.16',
+	major: 4, minor: 0, revision: 0, extra: '-beta2.17',
 	build: __webpack_hash__,
 	toString: () =>
 		`${VER.major}.${VER.minor}.${VER.revision}${VER.extra || ''}${DEBUG ? '-dev' : ''}`

src/modules/chat/emotes.js

@@ -128,10 +128,13 @@ export default class Emotes extends Module {
 	updateFollowSets(data) {
 		for(const room_login in data)
 			if ( has(data, room_login) ) {
-				const room = this.parent.getRoom(null, room_login, true),
+				const room = this.parent.getRoom(null, room_login, true);
-					new_sets = data[room_login] || [],
+				if ( ! room || room.destroyed )
+					continue;
+
+				const new_sets = data[room_login] || [],
 					emote_sets = room.emote_sets,
-					providers = emote_sets._sources;
+					providers = emote_sets && emote_sets._sources;
 
 				if ( providers && providers.has('featured') )
 					for(const item of providers.get('featured')) {

src/raven.js

@@ -152,7 +152,7 @@ export default class RavenLogger extends Module {
 			},
 			shouldSendCallback: data => {
 				if ( this.settings && ! this.settings.get('reports.error.enable') ) {
-					if ( data.tags.example && this.__example_waiter ) {
+					if ( data.tags && data.tags.example && this.__example_waiter ) {
 						this.__example_waiter(null);
 						this.__example_waiter = null;
 					}
@@ -160,12 +160,13 @@ export default class RavenLogger extends Module {
 					return false;
 				}
 
+				const exc = data.exception && data.exception.values[0];
+
 				// We don't want any of Sentry's junk.
-				if ( data.message && data.messages.includes('raven-js/') )
+				if ( data.message && data.messages.includes('raven-js/') || (exc && JSON.stringify(exc).includes('raven-js/')) )
 					return false;
 
 				// We don't want any of Mozilla's junk either.
-				const exc = data.exception && data.exception.values[0];
 				if ( exc && exc.type.startsWith('NS_') )
 					return false;
 

src/sites/twitch-twilight/modules/host-options.vue

@@ -56,7 +56,7 @@
 			</header>
 		</div>
 		<div
-			v-show="activeTab === 'settings'"
+			v-if="activeTab === 'settings'"
 			:class="{ active: activeTab === 'settings'}"
 			class="tab tw-overflow-hidden"
 		>
@@ -178,6 +178,7 @@
 					<span>{{ t('metadata.host.tab.auto-host', 'Auto Host') }}</span>
 				</div>
 				<div
+					v-if="autoHostSettings"
 					id="host-options__settings"
 					:class="{active: activeTab === 'settings'}"
 					class="host-options__tab tw-pd-x-1"