oss/FrankerFaceZ
oss/FrankerFaceZ
1
0
Fork 0
mirror of https://github.com/FrankerFaceZ/FrankerFaceZ.git synced 2025-08-03 08:28:31 +00:00
Code Wiki Activity

Treat all strings from read buffers as gc-tainted

Browse source 
Rule: Copies must be made before retaining the string.
This commit is contained in:
Kane York 2016-01-17 19:46:01 -08:00
parent fdbcfe98dd
commit 43ecbff656
6 changed files with 37 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

16
socketserver/server/intern.go
View file

@ -6,19 +6,23 @@ import (
type StringPool struct {
sync.RWMutex
lookup map[string]Command
lookup map[string]string
}
func NewStringPool() *StringPool {
return &StringPool{lookup: make(map[string]Command)}
return &StringPool{lookup: make(map[string]string)}
}
// doesn't lock, doesn't check for dupes.
func (p *StringPool) _Intern_Setup(s string) {
p.lookup[s] = Command(s)
p.lookup[s] = s
}
func (p *StringPool) Intern(s string) Command {
func (p *StringPool) InternCommand(s string) Command {
return Command(p.Intern(s))
}
func (p *StringPool) Intern(s string) string {
p.RLock()
ss, exists := p.lookup[s]
p.RUnlock()
@ -32,7 +36,7 @@ func (p *StringPool) Intern(s string) Command {
if exists {
return ss
}
ss = Command(string([]byte(s))) // make a copy
p.lookup[s] = ss
ss = copyString(s)
p.lookup[ss] = ss
return ss
}