oss/FrankerFaceZ
oss/FrankerFaceZ
1
0
Fork 0
mirror of https://github.com/FrankerFaceZ/FrankerFaceZ.git synced 2025-06-27 21:05:53 +00:00
Code Wiki Activity

4.23.1

Browse source 
* Added: Add a `Reset` button to the headers of the badge visibility controls.
* Changed: Move some Twitch badges into a new `Twitch: Other` category.
* Changed: Do not display the badges in a category when the category is hidden to save space.
* Changed: Expose more data on emotes/emoji to tab completion.
* Fixed: Missing localization for certain items in Chat > Actions > Rooms.
* API Fixed: Ensure that emote set and badge IDs are cast to strings for consistent comparisons.
* API Fixed: Fix reference counting issues for emote sets when a set or badge is added from multiple providers.
* API Changed: Newly loaded emote sets are automatically scheduled for garbage collection if they have no users.
* API Changed: Added `removeAllSets(provider)` method to `Room`s and `Users`s.
* API Changed: Standardize `addSet(provider, set_id, data)` to allow passing set data in `Room` and `User`.
* API Changed: `addSet(...)` and `removeSet(...)` now return a boolean of whether or not the set was added or removed.
This commit is contained in:
SirStendec 2021-06-10 18:53:16 -04:00
parent a74faa95d3
commit 2a57ecb8a7
9 changed files with 188 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

42
src/modules/chat/emotes.js
View file

@ -57,7 +57,6 @@ const MODIFIERS = {
};
export default class Emotes extends Module {
constructor(...args) {
super(...args);
@ -636,30 +635,42 @@ export default class Emotes extends Module {
// ========================================================================
addDefaultSet(provider, set_id, data) {
let changed = false;
if ( typeof set_id === 'number' )
set_id = `${set_id}`;
let changed = false, added = false;
if ( ! this.default_sets.sourceIncludes(provider, set_id) ) {
changed = ! this.default_sets.includes(set_id);
this.default_sets.push(provider, set_id);
this.refSet(set_id);
changed = true;
added = true;
}
if ( data )
this.loadSetData(set_id, data);
if ( changed )
if ( changed ) {
this.refSet(set_id);
this.emit(':update-default-sets', provider, set_id, true);
}
return added;
}
removeDefaultSet(provider, set_id) {
let changed = false;
if ( typeof set_id === 'number' )
set_id = `${set_id}`;
if ( this.default_sets.sourceIncludes(provider, set_id) ) {
this.default_sets.remove(provider, set_id);
this.unrefSet(set_id);
changed = true;
if ( ! this.default_sets.includes(set_id) ) {
this.unrefSet(set_id);
this.emit(':update-default-sets', provider, set_id, false);
}
return true;
}
if ( changed )
this.emit(':update-default-sets', provider, set_id, false);
return false;
}
refSet(set_id) {
@ -668,7 +679,6 @@ export default class Emotes extends Module {
clearTimeout(this._set_timers[set_id]);
this._set_timers[set_id] = null;
}
}
unrefSet(set_id) {
@ -885,6 +895,11 @@ export default class Emotes extends Module {
this.log.info(`Loaded emote set #${set_id}: ${data.title} (${count} emotes)`);
this.emit(':loaded', set_id, data);
// Don't let people endlessly load unused sets.
const refs = this._set_refs[set_id] || 0;
if ( refs <= 0 && ! this._set_timers[set_id] )
this._set_timers[set_id] = setTimeout(() => this.unloadSet(set_id), 5000);
}
@ -904,6 +919,11 @@ export default class Emotes extends Module {
if ( ! suppress_log )
this.log.info(`Unloaded emote set #${set_id}: ${old_set.title}`);
if ( this._set_timers[set_id] ) {
clearTimeout(this._set_timers[set_id]);
this._set_timers[set_id] = null;
}
this.emit(':unloaded', set_id, old_set);
this.emote_sets[set_id] = null;
}