From 161b084626ef4dea4108e1ea2b20112f04d227b1 Mon Sep 17 00:00:00 2001 From: SirStendec Date: Thu, 19 Apr 2018 16:39:16 -0400 Subject: [PATCH] Stop using `thing.parentElement.removeChild(thing)`. Also make sure the block exists in ManagedStyles before we remove it. --- src/sites/twitch-twilight/modules/directory/index.jsx | 2 +- src/utilities/dom.js | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sites/twitch-twilight/modules/directory/index.jsx b/src/sites/twitch-twilight/modules/directory/index.jsx index 07996ccd..c5942afc 100644 --- a/src/sites/twitch-twilight/modules/directory/index.jsx +++ b/src/sites/twitch-twilight/modules/directory/index.jsx @@ -224,7 +224,7 @@ export default class Directory extends SiteModule { } if ( inst.ffz_uptime_el ) { - inst.ffz_uptime_el.parentElement.removeChild(inst.ffz_uptime_el); + inst.ffz_uptime_el.remove(); inst.ffz_uptime_el = null; inst.ffz_uptime_span = null; inst.ffz_uptime_tt = null; diff --git a/src/utilities/dom.js b/src/utilities/dom.js index 9ea68aff..a9be729c 100644 --- a/src/utilities/dom.js +++ b/src/utilities/dom.js @@ -155,7 +155,9 @@ export class ManagedStyle { delete(key) { const block = this._blocks[key]; if ( block ) { - this._style.removeChild(block); + if ( this._style.contains(block) ) + this._style.removeChild(block); + this._blocks[key] = null; } }