Resolve Reviews

Signed-off-by: divyansh42 <diagrawa@redhat.com>
This commit is contained in:
divyansh42 2021-01-28 20:52:10 +05:30
parent 3b62e47486
commit c83fdad66a
4 changed files with 6 additions and 6 deletions

View file

@ -34,7 +34,7 @@ Refer to the [`podman push`](http://docs.podman.io/en/latest/markdown/podman-man
<td>tags</td> <td>tags</td>
<td>No</td> <td>No</td>
<td> <td>
The tag or tags of the image to push. For multiple tags, seperate by a space. For example, <code>latest {{ github.sha }}</code><br> The tag or tags of the image to push. For multiple tags, seperate by a space. For example, <code>latest ${{ github.sha }}</code><br>
Defaults to <code>latest</code>. Defaults to <code>latest</code>.
</td> </td>
</tr> </tr>
@ -78,7 +78,7 @@ For example, `[ quay.io/username/spring-image:v1,quay.io/username/spring-image:l
`digest`: The pushed image digest, as written to the `digestfile`.<br> `digest`: The pushed image digest, as written to the `digestfile`.<br>
For example, `sha256:66ce924069ec4181725d15aa27f34afbaf082f434f448dc07a42daa3305cdab3`. For example, `sha256:66ce924069ec4181725d15aa27f34afbaf082f434f448dc07a42daa3305cdab3`.
For multiple tags, the digest remains same. For multiple tags, the digest is the same.
## Examples ## Examples

2
dist/index.js vendored

File diff suppressed because one or more lines are too long

2
dist/index.js.map vendored

File diff suppressed because one or more lines are too long

View file

@ -207,10 +207,10 @@ async function isPodmanLocalImageLatest(): Promise<boolean> {
// remove the pulled image from the Podman image storage // remove the pulled image from the Podman image storage
async function removeDockerImage(): Promise<void> { async function removeDockerImage(): Promise<void> {
if (imageToPush) { if (imageToPush) {
core.info(`Removing ${imageToPush} from the Podman image storage`);
for (const tag of tagsList) { for (const tag of tagsList) {
const imageWithTag = `${imageToPush}:${tag}`; const imageWithTag = `${imageToPush}:${tag}`;
await execute(await getPodmanPath(), [ "rmi", imageWithTag ]); await execute(await getPodmanPath(), [ "rmi", imageWithTag ]);
core.info(`Removing ${imageWithTag} from the Podman image storage`);
} }
} }
} }