actions/buildah-build
2
0
Fork 0
mirror of https://github.com/redhat-actions/buildah-build.git synced 2025-04-20 09:01:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix terminology around build types

Browse source 
"Building with Docker" implies docker is being used to build the image
instead of buildah.

"Building from scratch" implies building an image without a parent
image.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
This commit is contained in:
Luiz Carvalho 2020-12-10 09:09:41 -05:00
parent 27067e030d
commit f4bd46caff
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
README.md
View file

@ -120,11 +120,11 @@ envs: |
## Build Types ## Build Types
You can configure the `buildah` action to build your image using one or more Dockerfiles, or from scratch. You can configure the `buildah` action to build your image using one or more Dockerfiles, or none at all.
### Building using Docker ### Building using Dockerfiles
If you have been using Docker and have an existing Dockerfile, `buildah` can reuse your dockerfile. If you have been building your images with an existing Dockerfile, `buildah` can reuse your Dockerfile.
In this case the inputs needed are `image` and `dockerfiles`. `tag` is also recommended. If your Dockerfile requires ARGs, these can be passed using `build-arg`. In this case the inputs needed are `image` and `dockerfiles`. `tag` is also recommended. If your Dockerfile requires ARGs, these can be passed using `build-arg`.
@ -151,11 +151,11 @@ jobs:
some_arg=some_value some_arg=some_value
``` ```
### Building from scratch ### Building without a Dockerfile
Building from scratch requires more inputs, that would normally be specified in the Dockerfile. Building without a Dockerfile requires additional inputs, that would normally be specified in the Dockerfile.
Do not set `dockerfiles` if you are doing a build from scratch, or a docker build will be performed, and the other inputs will be ignored. Do not set `dockerfiles` if you are doing a build from scratch. Otherwise those Dockerfiles will be used, and the inputs below will be ignored.
- An output `image` name and usually a `tag`. - An output `image` name and usually a `tag`.
- `base-image` - `base-image`