From 40f7d0fb5f85e26dfe7b25b30e6c8ffdf76ec8cb Mon Sep 17 00:00:00 2001 From: divyansh42 Date: Tue, 16 Feb 2021 23:25:35 +0530 Subject: [PATCH] Resolve Reviews Signed-off-by: divyansh42 --- .github/workflows/dockerfile_build.yml | 8 +++----- .github/workflows/scratch_build.yml | 2 +- README.md | 20 ++++---------------- 3 files changed, 8 insertions(+), 22 deletions(-) diff --git a/.github/workflows/dockerfile_build.yml b/.github/workflows/dockerfile_build.yml index b03de80..91e7a0a 100644 --- a/.github/workflows/dockerfile_build.yml +++ b/.github/workflows/dockerfile_build.yml @@ -1,17 +1,15 @@ # This workflow will perform a test whenever there # is some change in code done to ensure that the changes # are not buggy and we are getting the desired output. -name: Test Build with dockerfile +name: Build from dockerfile on: [push, pull_request, workflow_dispatch] env: - PROJECT_DIR: spring-petclinic - IMAGE_NAME: spring-petclinic - MVN_REPO_DIR: ~/.m2/repository + IMAGE_NAME: "hello-world" jobs: build: name: Build image using Buildah - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: # Checkout buildah action github repository diff --git a/.github/workflows/scratch_build.yml b/.github/workflows/scratch_build.yml index 60be1d5..2c54250 100644 --- a/.github/workflows/scratch_build.yml +++ b/.github/workflows/scratch_build.yml @@ -1,7 +1,7 @@ # This workflow will perform a test whenever there # is some change in code done to ensure that the changes # are not buggy and we are getting the desired output. -name: Test Build without dockerfile +name: Build from scratch on: [push, pull_request, workflow_dispatch] env: PROJECT_DIR: spring-petclinic diff --git a/README.md b/README.md index 6308ea4..2ce0618 100644 --- a/README.md +++ b/README.md @@ -21,11 +21,11 @@ After building your image, use [push-to-registry](https://github.com/redhat-acti | Input Name | Description | Default | | ---------- | ----------- | ------- | -| build-args | Build arguments to pass to the Docker build using `--build-arg`, if using a Dockerfile that requires ARGs. Uses the form `arg_name=arg_value`, and separate arguments with newlines. | None +| build-args | Build arguments to pass to the Docker build using `--build-arg`, if using a Dockerfile that requires ARGs. Use the form `arg_name=arg_value`, and separate arguments with newlines. | None | context | Path to directory to use as the build context. | `.` | dockerfiles | The list of Dockerfile paths to perform a build using docker instructions. This is a multiline input to allow multiple Dockerfiles. | **Must be provided** | image | Name to give to the output image. | **Must be provided** -| oci | Build the image using the OCI format, instead of the Docker format. By default, this is `false`, because images built using the OCI format have issues when published to `Dockerhub`. | `false` +| oci | Build the image using the OCI format, instead of the Docker format. By default, this is `false`, because images built using the OCI format have issues when published to Dockerhub. | `false` | tags | The tags of the image to build. For multiple tags, separate by a space. For example, `latest ${{ github.sha }}` | `latest` ### Inputs for build without dockerfile @@ -33,12 +33,12 @@ After building your image, use [push-to-registry](https://github.com/redhat-acti | Input Name | Description | Default | | ---------- | ----------- | ------- | | base-image | The base image to use for the container. | **Must be provided** -| content | The content to copy inside the container to create the final image. This is a multiline input to allow you to copy more than one file/directory.| No +| content | Paths to files or directories to copy inside the container to create the file image. This is a multiline input to allow you to copy multiple files/directories.| None | context | Path to directory to use as the build context. | `.` | entrypoint | The entry point to set for the container. This is a multiline input; split arguments across lines. | None | envs | The environment variables to be set when running the container. This is a multiline input to add multiple environment variables. | None | image | Name to give to the output image. | **Must be provided** -| oci | Build the image using the OCI format, instead of the Docker format. By default, this is `false`, because images built using the OCI format have issues when published to `Dockerhub`. | `false` +| oci | Build the image using the OCI format, instead of the Docker format. By default, this is `false`, because images built using the OCI format have issues when published to Dockerhub. | `false` | port | The port to expose when running the container. | None | tags | The tags of the image to build. For multiple tags, separate by a space. For example, `latest ${{ github.sha }}` | `latest` | workdir | The working directory to use within the container. | None @@ -134,15 +134,3 @@ For example: - name: Log in to Red Hat Registry run: echo "${{ secrets.REGISTRY_REDHAT_IO_PASSWORD }}" | docker login registry.redhat.io -u "${{ secrets.REGISTRY_REDHAT_IO_USER }}" --password-stdin ``` - -## Contributing - -This is an open source project open to anyone. This project welcomes contributions and suggestions! - -## Feedback & Questions - -If you discover an issue please file a bug in [GitHub issues](https://github.com/redhat-actions/buildah-build/issues) and we will fix it as soon as possible. - -## License - -MIT, See [LICENSE](https://github.com/redhat-actions/buildah-build/blob/main/LICENSE) for more information.